feat: turn streaming on by default #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request enables query streaming by default and refactors the UI for query timeout settings.
- Introduces a new QuerySettingsTimeout component to handle timeout inputs.
- Updates the QuerySettingsDialog to replace inline timeout control with the new component and changes the docs link from ExternalLink to Button.
- Adjusts default streaming settings and the capability version check for streaming.
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsTimeout.tsx | New component to encapsulate timeout settings in the query dialog. |
| src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx | Integrates the new timeout component and updates the docs link. |
| src/utils/query.ts | Updates the timeout field validation schema by removing the default value catch. |
| src/services/settings.ts | Changes default query streaming setting to true. |
| src/store/reducers/capabilities/hooks.ts | Updates the minimum version requirement for streaming availability. |
Files not reviewed (4)
- src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.scss: Language not supported
- src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsTimeout.scss: Language not supported
- src/containers/Tenant/Query/QuerySettingsDialog/i18n/en.json: Language not supported
- src/containers/Tenant/Query/QuerySettingsDialog/i18n/ru.json: Language not supported
Comments suppressed due to low confidence (1)
src/utils/query.ts:332
- Removing the default catch for the timeout value might lead to issues when processing empty or invalid inputs. If a default value is desired, consider handling it explicitly.
z.coerce.number().positive().optional()
src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx
Outdated
Show resolved
Hide resolved
Raubzeug
requested changes
Mar 26, 2025
| content={QUERY_SETTINGS_FIELD_SETTINGS.timeout.title} | ||
| /> | ||
| {isDisabled ? ( | ||
| <Popover |
There was a problem hiding this comment.
|
|
||
| const isChecked = value !== null; | ||
|
|
||
| const queryStreamingLabel = isQueryStreamingEnabled ? ( |
There was a problem hiding this comment.
maybe rename to timeoutLabel? And I would do it a separate component (not a demand, just suggestion).
| className={b('switch')} | ||
| content={QUERY_SETTINGS_FIELD_SETTINGS.timeout.title} | ||
| /> | ||
| {isDisabled ? ( |
|
@Raubzeug fixed |
Raubzeug
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2024
Stand
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ✨4 ⏭️1
✨ New Tests (4)
⏭️ Skipped Tests (1)
Bundle Size: 🔺
Current: 83.24 MB | Main: 83.23 MB
Diff: +9.87 KB (0.01%)
ℹ️ CI Information